fix: Missing descriptions on Kotlin ByteArray fields #2711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where information specified via {{@Schema}} annotations on {{ByteArray}} fields was missing if Kotlin transformations were enabled.
As far as I can tell, the code I removed was only necessary as a workaround for swagger-api/swagger-core#3944, which has now been fixed.
I've extended a related test added in #2006 to show that the {{description}} is now present in the generated schema.
Fixes #2275 (The issue is currently closed as wontfix, but I hope you'll accept this fix.)